fix mantainance page throws vue warnings #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munyanezaarmel
force-pushed
the
fix-mantainance-page-warnings
branch
from
bc7e836 to
dc4a9a3
Compare
|
Hey @munyanezaarmel nice 🙏 Two general comments:
|
|
@dmohns check again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
:value expects a simple data type, but we are currently passing an object so we have to use employee id instead of full employee object to md-option value prop
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Closes: #145
Pull Request checklist
Please confirm you have completed any of the necessary steps below.